Built by Maven

Checkstyle Results

The following document contains the results of Checkstyle 10.12.7 with checkstyle.xml ruleset.

Summary

Files  Info  Warnings  Errors
65 0 108 0

Files

File  I  W  E
waffle/jaas/RolePrincipalTest.java 0 1 0
waffle/jaas/UserPrincipalTest.java 0 1 0
waffle/jaas/UsernamePasswordCallbackHandler.java 0 1 0
waffle/jaas/WindowsLoginModule.java 0 3 0
waffle/jaas/WindowsLoginModuleTest.java 0 5 0
waffle/servlet/AutoDisposableWindowsPrincipal.java 0 1 0
waffle/servlet/CorsAwareNegotiateSecurityFilter.java 0 4 0
waffle/servlet/CorsAwareNegotiateSecurityFilterTest.java 0 3 0
waffle/servlet/NegotiateRequestWrapper.java 0 1 0
waffle/servlet/NegotiateSecurityFilter.java 0 4 0
waffle/servlet/NegotiateSecurityFilterTest.java 0 7 0
waffle/servlet/WaffleInfoServlet.java 0 3 0
waffle/servlet/WindowsPrincipal.java 0 2 0
waffle/servlet/WindowsPrincipalTest.java 0 2 0
waffle/servlet/spi/BasicSecurityFilterProvider.java 0 3 0
waffle/servlet/spi/NegotiateSecurityFilterProvider.java 0 3 0
waffle/servlet/spi/SecurityFilterProvider.java 0 2 0
waffle/servlet/spi/SecurityFilterProviderCollection.java 0 4 0
waffle/servlet/spi/SecurityFilterProviderCollectionTest.java 0 1 0
waffle/util/AuthorizationHeader.java 0 3 0
waffle/util/CorsPreFlightCheck.java 0 3 0
waffle/util/CorsPreflightCheckTest.java 0 4 0
waffle/util/SPNegoMessage.java 0 1 0
waffle/util/SPNegoMessageTest.java 0 1 0
waffle/util/WaffleInfo.java 0 9 0
waffle/util/WaffleInfoTest.java 0 3 0
waffle/util/cache/Cache.java 0 6 0
waffle/util/cache/CacheSupplier.java 0 1 0
waffle/util/cache/CaffeineCache.java 0 3 0
waffle/windows/auth/IWindowsAccount.java 0 1 0
waffle/windows/auth/IWindowsAuthProvider.java 0 1 0
waffle/windows/auth/IWindowsComputer.java 0 1 0
waffle/windows/auth/IWindowsCredentialsHandle.java 0 1 0
waffle/windows/auth/IWindowsDomain.java 0 1 0
waffle/windows/auth/IWindowsIdentity.java 0 1 0
waffle/windows/auth/IWindowsImpersonationContext.java 0 1 0
waffle/windows/auth/IWindowsSecurityContext.java 0 1 0
waffle/windows/auth/WindowsAccountTest.java 0 1 0
waffle/windows/auth/WindowsCredentialsHandleTest.java 0 1 0
waffle/windows/auth/WindowsSecurityContextTest.java 0 1 0
waffle/windows/auth/impl/WindowsAccountImpl.java 0 1 0
waffle/windows/auth/impl/WindowsAuthProviderImpl.java 0 2 0
waffle/windows/auth/impl/WindowsComputerImpl.java 0 2 0
waffle/windows/auth/impl/WindowsCredentialsHandleImpl.java 0 1 0
waffle/windows/auth/impl/WindowsDomainImpl.java 0 1 0
waffle/windows/auth/impl/WindowsIdentityImpersonationContextImpl.java 0 1 0
waffle/windows/auth/impl/WindowsIdentityImpl.java 0 2 0
waffle/windows/auth/impl/WindowsSecurityContextImpersonationContextImpl.java 0 1 0
waffle/windows/auth/impl/WindowsSecurityContextImpl.java 0 1 0

Rules

Category Rule Violations Severity
coding OverloadMethodsDeclarationOrder 1  Warning
imports CustomImportOrder
  • separateLineBetweenGroups: "true"
  • sortImportsInGroupAlphabetically: "true"
  • customImportOrderRules: "STATIC###THIRD_PARTY_PACKAGE"
  • tokens: "IMPORT, STATIC_IMPORT, PACKAGE_DEF"
 74  Warning
javadoc InvalidJavadocPosition 2  Warning
JavadocParagraph 7  Warning
SummaryJavadoc
  • forbiddenSummaryFragments: "^@return the *|^This method returns |^A [{]@code [a-zA-Z0-9]+[}]( is a )"
 6  Warning
misc OuterTypeFilename 1  Warning
naming AbbreviationAsWordInName
  • tokens: "CLASS_DEF, INTERFACE_DEF, ENUM_DEF, ANNOTATION_DEF, ANNOTATION_FIELD_DEF, PARAMETER_DEF, VARIABLE_DEF, METHOD_DEF, PATTERN_VARIABLE_DEF, RECORD_DEF, RECORD_COMPONENT_DEF"
  • ignoreFinal: "false"
  • allowedAbbreviations: "XML,URL"
  • allowedAbbreviationLength: "0"
 14  Warning
sizes LineLength
  • fileExtensions: "java"
  • max: "120"
  • ignorePattern: "^package.*|^import.*|a href|href|http://|https://|ftp://"
 3  Error

Details

waffle/jaas/RolePrincipalTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'org.junit.jupiter.api.Assertions' 35

waffle/jaas/UserPrincipalTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'org.junit.jupiter.api.Assertions' 35

waffle/jaas/UsernamePasswordCallbackHandler.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'javax.security.auth.callback.Callback' 28

waffle/jaas/WindowsLoginModule.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'javax.security.auth.Subject' 35
 Warning imports CustomImportOrder Extra separation in import group before 'org.slf4j.Logger' 44
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsAccount' 47

waffle/jaas/WindowsLoginModuleTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'javax.security.auth.Subject' 33
 Warning imports CustomImportOrder Extra separation in import group before 'mockit.Expectations' 40
 Warning imports CustomImportOrder Extra separation in import group before 'org.junit.jupiter.api.Assertions' 43
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.PrincipalFormat' 48
 Warning naming AbbreviationAsWordInName Abbreviation in name 'login_throwIOException' must contain no more than '1' consecutive capital letters. 232

waffle/servlet/AutoDisposableWindowsPrincipal.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsIdentity' 29

waffle/servlet/CorsAwareNegotiateSecurityFilter.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'javax.servlet.Filter' 28
 Warning imports CustomImportOrder Extra separation in import group before 'org.slf4j.Logger' 36
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.util.AuthorizationHeader' 39
 Warning sizes LineLength Line is longer than 120 characters (found 122). 75

waffle/servlet/CorsAwareNegotiateSecurityFilterTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'mockit.Expectations' 31
 Warning imports CustomImportOrder Extra separation in import group before 'org.junit.jupiter.api.Test' 36
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.util.CorsPreFlightCheck' 38

waffle/servlet/NegotiateRequestWrapper.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'javax.servlet.http.HttpServletRequest' 28

waffle/servlet/NegotiateSecurityFilter.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'javax.security.auth.Subject' 35
 Warning imports CustomImportOrder Extra separation in import group before 'org.slf4j.Logger' 46
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.servlet.spi.SecurityFilterProvider' 49
 Warning naming AbbreviationAsWordInName Abbreviation in name 'disableSSO' must contain no more than '1' consecutive capital letters. 101

waffle/servlet/NegotiateSecurityFilterTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'javax.servlet.FilterChain' 30
 Warning imports CustomImportOrder Extra separation in import group before 'mockit.Expectations' 35
 Warning imports CustomImportOrder Extra separation in import group before 'org.junit.jupiter.api.Assertions' 40
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.util.CorsPreFlightCheck' 43
 Warning sizes LineLength Line is longer than 120 characters (found 131). 99
 Warning naming AbbreviationAsWordInName Abbreviation in name 'testExcludeCorsAndOAUTHBearerAuthorization_doFilter' must contain no more than '1' consecutive capital letters. 147
 Warning sizes LineLength Line is longer than 120 characters (found 131). 165

waffle/servlet/WaffleInfoServlet.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'javax.servlet.http.HttpServlet' 31
 Warning imports CustomImportOrder Extra separation in import group before 'org.slf4j.Logger' 43
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.util.WaffleInfo' 48

waffle/servlet/WindowsPrincipal.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsAccount' 33
 Warning coding OverloadMethodsDeclarationOrder All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '124'. 155

waffle/servlet/WindowsPrincipalTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'org.junit.jupiter.api.Assertions' 29
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsAccount' 32

waffle/servlet/spi/BasicSecurityFilterProvider.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'javax.servlet.http.HttpServletRequest' 30
 Warning imports CustomImportOrder Extra separation in import group before 'org.slf4j.Logger' 33
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.util.AuthorizationHeader' 36

waffle/servlet/spi/NegotiateSecurityFilterProvider.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'javax.servlet.http.HttpServletRequest' 32
 Warning imports CustomImportOrder Extra separation in import group before 'org.slf4j.Logger' 35
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.util.AuthorizationHeader' 38

waffle/servlet/spi/SecurityFilterProvider.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'javax.servlet.http.HttpServletRequest' 28
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsIdentity' 31

waffle/servlet/spi/SecurityFilterProviderCollection.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'java.io.IOException' 28
 Warning imports CustomImportOrder Extra separation in import group before 'javax.servlet.http.HttpServletRequest' 34
 Warning imports CustomImportOrder Extra separation in import group before 'org.slf4j.Logger' 37
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.util.AuthorizationHeader' 40

waffle/servlet/spi/SecurityFilterProviderCollectionTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.impl.WindowsAuthProviderImpl' 29

waffle/util/AuthorizationHeader.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'javax.servlet.http.HttpServletRequest' 29
 Warning imports CustomImportOrder Extra separation in import group before 'org.slf4j.Logger' 31
 Warning naming AbbreviationAsWordInName Abbreviation in name 'isSPNegTokenInitMessage' must contain no more than '1' consecutive capital letters. 150

waffle/util/CorsPreFlightCheck.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'javax.servlet.http.HttpServletRequest' 30
 Warning imports CustomImportOrder Extra separation in import group before 'org.slf4j.Logger' 32
 Warning javadoc InvalidJavadocPosition Javadoc comment is placed in the wrong location. 80

waffle/util/CorsPreflightCheckTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'mockit.Expectations' 28
 Warning imports CustomImportOrder Extra separation in import group before 'org.junit.jupiter.api.Assertions' 32
 Warning misc OuterTypeFilename The name of the outer type and the file do not match. 38
 Warning javadoc InvalidJavadocPosition Javadoc comment is placed in the wrong location. 104

waffle/util/SPNegoMessage.java

Severity Category Rule Message Line
 Warning naming AbbreviationAsWordInName Abbreviation in name 'SPNegoMessage' must contain no more than '1' consecutive capital letters. 31

waffle/util/SPNegoMessageTest.java

Severity Category Rule Message Line
 Warning naming AbbreviationAsWordInName Abbreviation in name 'SPNegoMessageTest' must contain no more than '1' consecutive capital letters. 34

waffle/util/WaffleInfo.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'java.awt.Desktop' 32
 Warning imports CustomImportOrder Extra separation in import group before 'javax.xml.XMLConstants' 43
 Warning imports CustomImportOrder Extra separation in import group before 'org.slf4j.Logger' 53
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsAccount' 58
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 71
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 79
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 87
 Warning javadoc JavadocParagraph <p> tag should be placed immediately before the first word, with no space after. 103
 Warning javadoc JavadocParagraph <p> tag should be preceded with an empty line. 103

waffle/util/WaffleInfoTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'javax.xml.parsers.ParserConfigurationException' 28
 Warning imports CustomImportOrder Extra separation in import group before 'org.junit.jupiter.api.Assertions' 30
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsAccount' 37

waffle/util/cache/Cache.java

Severity Category Rule Message Line
 Warning javadoc JavadocParagraph <p> tag should be placed immediately before the first word, with no space after. 46
 Warning javadoc JavadocParagraph <p> tag should be preceded with an empty line. 46
 Warning javadoc SummaryJavadoc First sentence of Javadoc is missing an ending period. 75
 Warning javadoc SummaryJavadoc First sentence of Javadoc is missing an ending period. 87
 Warning javadoc SummaryJavadoc First sentence of Javadoc is missing an ending period. 99
 Warning javadoc SummaryJavadoc First sentence of Javadoc is missing an ending period. 109

waffle/util/cache/CacheSupplier.java

Severity Category Rule Message Line
 Warning javadoc SummaryJavadoc First sentence of Javadoc is missing an ending period. 33

waffle/util/cache/CaffeineCache.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'java.time.Duration' 28
 Warning imports CustomImportOrder Extra separation in import group before 'org.checkerframework.checker.index.qual.NonNegative' 30
 Warning javadoc SummaryJavadoc First sentence of Javadoc is missing an ending period. 32

waffle/windows/auth/IWindowsAccount.java

Severity Category Rule Message Line
 Warning naming AbbreviationAsWordInName Abbreviation in name 'IWindowsAccount' must contain no more than '1' consecutive capital letters. 29

waffle/windows/auth/IWindowsAuthProvider.java

Severity Category Rule Message Line
 Warning naming AbbreviationAsWordInName Abbreviation in name 'IWindowsAuthProvider' must contain no more than '1' consecutive capital letters. 29

waffle/windows/auth/IWindowsComputer.java

Severity Category Rule Message Line
 Warning naming AbbreviationAsWordInName Abbreviation in name 'IWindowsComputer' must contain no more than '1' consecutive capital letters. 29

waffle/windows/auth/IWindowsCredentialsHandle.java

Severity Category Rule Message Line
 Warning naming AbbreviationAsWordInName Abbreviation in name 'IWindowsCredentialsHandle' must contain no more than '1' consecutive capital letters. 31

waffle/windows/auth/IWindowsDomain.java

Severity Category Rule Message Line
 Warning naming AbbreviationAsWordInName Abbreviation in name 'IWindowsDomain' must contain no more than '1' consecutive capital letters. 29

waffle/windows/auth/IWindowsIdentity.java

Severity Category Rule Message Line
 Warning naming AbbreviationAsWordInName Abbreviation in name 'IWindowsIdentity' must contain no more than '1' consecutive capital letters. 29

waffle/windows/auth/IWindowsImpersonationContext.java

Severity Category Rule Message Line
 Warning naming AbbreviationAsWordInName Abbreviation in name 'IWindowsImpersonationContext' must contain no more than '1' consecutive capital letters. 29

waffle/windows/auth/IWindowsSecurityContext.java

Severity Category Rule Message Line
 Warning naming AbbreviationAsWordInName Abbreviation in name 'IWindowsSecurityContext' must contain no more than '1' consecutive capital letters. 33

waffle/windows/auth/WindowsAccountTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.impl.WindowsAccountImpl' 33

waffle/windows/auth/WindowsCredentialsHandleTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.impl.WindowsCredentialsHandleImpl' 29

waffle/windows/auth/WindowsSecurityContextTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.impl.WindowsAccountImpl' 31

waffle/windows/auth/impl/WindowsAccountImpl.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsAccount' 31

waffle/windows/auth/impl/WindowsAuthProviderImpl.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'java.net.InetAddress' 40
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.util.cache.Cache' 45

waffle/windows/auth/impl/WindowsComputerImpl.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'java.util.ArrayList' 30
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsComputer' 33

waffle/windows/auth/impl/WindowsCredentialsHandleImpl.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsCredentialsHandle' 33

waffle/windows/auth/impl/WindowsDomainImpl.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsDomain' 28

waffle/windows/auth/impl/WindowsIdentityImpersonationContextImpl.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsImpersonationContext' 31

waffle/windows/auth/impl/WindowsIdentityImpl.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'java.util.ArrayList' 32
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsAccount' 35

waffle/windows/auth/impl/WindowsSecurityContextImpersonationContextImpl.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsImpersonationContext' 31

waffle/windows/auth/impl/WindowsSecurityContextImpl.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsCredentialsHandle' 36