SpotBugs Bug Detector Report
The following document contains the results of SpotBugs
SpotBugs Version is 4.10.4
Threshold is medium
Effort is
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 5 |
10 |
0 |
0 |
waffle.spring.boot.WaffleAutoConfiguration
| Bug |
Category |
Details |
Line |
Priority |
| new waffle.spring.boot.WaffleAutoConfiguration(WaffleProperties) may expose internal representation by storing an externally mutable object into WaffleAutoConfiguration.properties |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
49 |
Medium |
| waffle.spring.boot.WaffleAutoConfiguration.basicSecurityFilterProvider(WindowsAuthProviderImpl): 1st parameter 'windowsAuthProvider' could be declared as waffle.windows.auth.IWindowsAuthProvider instead |
STYLE |
OCP_OVERLY_CONCRETE_PARAMETER |
148 |
Medium |
| waffle.spring.boot.WaffleAutoConfiguration.negotiateSecurityFilterProvider(WindowsAuthProviderImpl): 1st parameter 'windowsAuthProvider' could be declared as waffle.windows.auth.IWindowsAuthProvider instead |
STYLE |
OCP_OVERLY_CONCRETE_PARAMETER |
130 |
Medium |
| waffle.spring.boot.WaffleAutoConfiguration.waffleNegotiateSecurityFilterRegistrationBean(NegotiateSecurityFilter): 1st parameter 'filter' could be declared as javax.servlet.Filter instead |
STYLE |
OCP_OVERLY_CONCRETE_PARAMETER |
239 |
Medium |
| waffle.spring.boot.WaffleAutoConfiguration.waffleSpringAuthenticationProvider(WindowsAuthProviderImpl, GrantedAuthority, GrantedAuthorityFactory): 1st parameter 'waffleWindowsAuthProvider' could be declared as waffle.windows.auth.IWindowsAuthProvider instead |
STYLE |
OCP_OVERLY_CONCRETE_PARAMETER |
106 |
Medium |
waffle.spring.boot.WaffleProperties
| Bug |
Category |
Details |
Line |
Priority |
| waffle.spring.boot.WaffleProperties.getSso() may expose internal representation by returning WaffleProperties.sso |
MALICIOUS_CODE |
EI_EXPOSE_REP |
97 |
Medium |
| waffle.spring.boot.WaffleProperties.setSso(WaffleProperties$SingleSignOnProperties) may expose internal representation by storing an externally mutable object into WaffleProperties.sso |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
107 |
Medium |
waffle.spring.boot.WaffleProperties$SingleSignOnProperties
| Bug |
Category |
Details |
Line |
Priority |
| waffle.spring.boot.WaffleProperties$SingleSignOnProperties.getProtocols() may expose internal representation by returning WaffleProperties$SingleSignOnProperties.protocols |
MALICIOUS_CODE |
EI_EXPOSE_REP |
171 |
Medium |
| waffle.spring.boot.WaffleProperties$SingleSignOnProperties.setProtocols(List) may expose internal representation by storing an externally mutable object into WaffleProperties$SingleSignOnProperties.protocols |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
181 |
Medium |
waffle.spring.boot.WafflePropertiesTest
| Bug |
Category |
Details |
Line |
Priority |
| Method waffle.spring.boot.WafflePropertiesTest.testSsoSetProtocols() builds a list from one element using Arrays.asList rather than Collections.singletonList |
CORRECTNESS |
LUI_USE_SINGLETON_LIST |
177 |
Medium |
