SpotBugs Bug Detector Report

The following document contains the results of SpotBugs

SpotBugs Version is 4.8.6

Threshold is medium

Effort is

Summary

Classes	Bugs	Errors	Missing Classes
18	19	0	3

Files

Class	Bugs
waffle.spring.DelegatingNegotiateSecurityFilter	5
waffle.spring.DelegatingNegotiateSecurityFilterTest	1
waffle.spring.ImpersonateTest	2
waffle.spring.NegotiateSecurityFilter	2
waffle.spring.NegotiateSecurityFilterEntryPointTest	2
waffle.spring.NegotiateSecurityFilterTest	1
waffle.spring.WindowsAuthenticationProviderTest	2
waffle.spring.WindowsAuthenticationToken	2
waffle.spring.WindowsAuthenticationTokenTest	2

waffle.spring.DelegatingNegotiateSecurityFilter

Bug	Category	Details	Line	Priority
To make log readable, log format () should contain non-sign character.	BAD_PRACTICE	SLF4J_SIGN_ONLY_FORMAT	157	Medium
To make log readable, log format () should contain non-sign character.	BAD_PRACTICE	SLF4J_SIGN_ONLY_FORMAT	203	Medium
To make log readable, log format () should contain non-sign character.	BAD_PRACTICE	SLF4J_SIGN_ONLY_FORMAT	207	Medium
To make log readable, log format () should contain non-sign character.	BAD_PRACTICE	SLF4J_SIGN_ONLY_FORMAT	232	Medium
To make log readable, log format () should contain non-sign character.	BAD_PRACTICE	SLF4J_SIGN_ONLY_FORMAT	236	Medium

waffle.spring.DelegatingNegotiateSecurityFilterTest

Bug	Category	Details	Line	Priority
Method waffle.spring.DelegatingNegotiateSecurityFilterTest.testNegotiate() does not presize the allocation of a collection	PERFORMANCE	PSC_PRESIZE_COLLECTIONS	133	Medium

waffle.spring.ImpersonateTest

Bug	Category	Details	Line	Priority
Method waffle.spring.ImpersonateTest.testImpersonateDisabled() appears to call the same method on the same object redundantly	PERFORMANCE	PRMC_POSSIBLY_REDUNDANT_METHOD_CALLS	178	High
Method waffle.spring.ImpersonateTest.testImpersonateEnabled() appears to call the same method on the same object redundantly	PERFORMANCE	PRMC_POSSIBLY_REDUNDANT_METHOD_CALLS	137	High

waffle.spring.NegotiateSecurityFilter

Bug	Category	Details	Line	Priority
Unconstrained method waffle.spring.NegotiateSecurityFilter.sendUnauthorized(HttpServletResponse, boolean) converts checked exception to unchecked	STYLE	EXS_EXCEPTION_SOFTENING_NO_CONSTRAINTS	211	High
To make log readable, log format () should contain non-sign character.	BAD_PRACTICE	SLF4J_SIGN_ONLY_FORMAT	114	Medium

waffle.spring.NegotiateSecurityFilterEntryPointTest

Bug	Category	Details	Line	Priority
Method waffle.spring.NegotiateSecurityFilterEntryPointTest.testChallengeGET() accesses list or array with constant index	CORRECTNESS	CLI_CONSTANT_LIST_INDEX	87	Medium
Method waffle.spring.NegotiateSecurityFilterEntryPointTest.testChallengeGET() accesses list or array with constant index	CORRECTNESS	CLI_CONSTANT_LIST_INDEX	88	Medium

waffle.spring.NegotiateSecurityFilterTest

Bug	Category	Details	Line	Priority
Method waffle.spring.NegotiateSecurityFilterTest.testNegotiate() does not presize the allocation of a collection	PERFORMANCE	PSC_PRESIZE_COLLECTIONS	162	Medium

waffle.spring.WindowsAuthenticationProviderTest

Bug	Category	Details	Line	Priority
Method waffle.spring.WindowsAuthenticationProviderTest.testAuthenticate() does not presize the allocation of a collection	PERFORMANCE	PSC_PRESIZE_COLLECTIONS	115	Medium
Method waffle.spring.WindowsAuthenticationProviderTest.testAuthenticateWithCustomGrantedAuthorityFactory() does not presize the allocation of a collection	PERFORMANCE	PSC_PRESIZE_COLLECTIONS	146	Medium

waffle.spring.WindowsAuthenticationToken

Bug	Category	Details	Line	Priority
waffle.spring.WindowsAuthenticationToken.getAuthorities() may expose internal representation by returning WindowsAuthenticationToken.authorities	MALICIOUS_CODE	EI_EXPOSE_REP	108	Medium
Method new waffle.spring.WindowsAuthenticationToken(WindowsPrincipal, GrantedAuthorityFactory, GrantedAuthority) does not presize the allocation of a collection	PERFORMANCE	PSC_PRESIZE_COLLECTIONS	102	Medium

waffle.spring.WindowsAuthenticationTokenTest

Bug	Category	Details	Line	Priority
Method waffle.spring.WindowsAuthenticationTokenTest.testCustomGrantedAuthorityFactory() does not presize the allocation of a collection	PERFORMANCE	PSC_PRESIZE_COLLECTIONS	104	Medium
Method waffle.spring.WindowsAuthenticationTokenTest.testWindowsAuthenticationToken() does not presize the allocation of a collection	PERFORMANCE	PSC_PRESIZE_COLLECTIONS	77	Medium