Checkstyle Results

The following document contains the results of Checkstyle 10.12.7 with checkstyle.xml ruleset.

Summary

Files  Info  Warnings  Errors
13 0 46 0

Files

File  I  W  E
waffle/apache/GenericWindowsPrincipal.java 0 3 0
waffle/apache/MixedAuthenticator.java 0 4 0
waffle/apache/MixedAuthenticatorTest.java 0 8 0
waffle/apache/NegotiateAuthenticator.java 0 4 0
waffle/apache/NegotiateAuthenticatorTest.java 0 7 0
waffle/apache/WaffleAuthenticatorBase.java 0 3 0
waffle/apache/WaffleAuthenticatorBaseTest.java 0 3 0
waffle/apache/WindowsAccountTest.java 0 2 0
waffle/apache/WindowsRealm.java 0 4 0
waffle/apache/catalina/SimpleHttpRequest.java 0 7 0
waffle/apache/catalina/SimpleHttpResponse.java 0 1 0

Rules

Category Rule Violations Severity
coding OverloadMethodsDeclarationOrder 1  Warning
imports CustomImportOrder
  • separateLineBetweenGroups: "true"
  • sortImportsInGroupAlphabetically: "true"
  • customImportOrderRules: "STATIC###THIRD_PARTY_PACKAGE"
  • tokens: "IMPORT, STATIC_IMPORT, PACKAGE_DEF"
32  Warning
javadoc JavadocParagraph 2  Warning
modifier ModifierOrder 2  Warning
naming AbbreviationAsWordInName
  • tokens: "CLASS_DEF, INTERFACE_DEF, ENUM_DEF, ANNOTATION_DEF, ANNOTATION_FIELD_DEF, PARAMETER_DEF, VARIABLE_DEF, METHOD_DEF, PATTERN_VARIABLE_DEF, RECORD_DEF, RECORD_COMPONENT_DEF"
  • ignoreFinal: "false"
  • allowedAbbreviations: "XML,URL"
  • allowedAbbreviationLength: "0"
9  Warning

Details

waffle/apache/GenericWindowsPrincipal.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'org.apache.catalina.realm.GenericPrincipal' 31
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsAccount' 33
 Warning coding OverloadMethodsDeclarationOrder All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '103'. 134

waffle/apache/MixedAuthenticator.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'jakarta.servlet.RequestDispatcher' 28
 Warning imports CustomImportOrder Extra separation in import group before 'java.io.IOException' 34
 Warning imports CustomImportOrder Extra separation in import group before 'org.apache.catalina.LifecycleException' 38
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.util.AuthorizationHeader' 44

waffle/apache/MixedAuthenticatorTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'jakarta.servlet.ServletException' 31
 Warning imports CustomImportOrder Extra separation in import group before 'java.util.Base64' 33
 Warning imports CustomImportOrder Extra separation in import group before 'mockit.Expectations' 36
 Warning imports CustomImportOrder Extra separation in import group before 'org.apache.catalina.Context' 39
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.apache.catalina.SimpleHttpRequest' 48
 Warning naming AbbreviationAsWordInName Abbreviation in name 'testChallengeGET' must contain no more than '1' consecutive capital letters. 110
 Warning naming AbbreviationAsWordInName Abbreviation in name 'testChallengePOST' must contain no more than '1' consecutive capital letters. 130
 Warning naming AbbreviationAsWordInName Abbreviation in name 'testProgrammaticSecuritySID' must contain no more than '1' consecutive capital letters. 298

waffle/apache/NegotiateAuthenticator.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'jakarta.servlet.http.HttpServletResponse' 28
 Warning imports CustomImportOrder Extra separation in import group before 'java.io.IOException' 31
 Warning imports CustomImportOrder Extra separation in import group before 'org.apache.catalina.LifecycleException' 35
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.util.AuthorizationHeader' 40

waffle/apache/NegotiateAuthenticatorTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'java.util.Base64' 31
 Warning imports CustomImportOrder Extra separation in import group before 'mockit.Expectations' 33
 Warning imports CustomImportOrder Extra separation in import group before 'org.apache.catalina.Context' 36
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.apache.catalina.SimpleHttpRequest' 44
 Warning naming AbbreviationAsWordInName Abbreviation in name 'testChallengeGET' must contain no more than '1' consecutive capital letters. 113
 Warning naming AbbreviationAsWordInName Abbreviation in name 'testChallengePOST' must contain no more than '1' consecutive capital letters. 132
 Warning naming AbbreviationAsWordInName Abbreviation in name 'testPOSTEmpty' must contain no more than '1' consecutive capital letters. 244

waffle/apache/WaffleAuthenticatorBase.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'java.io.IOException' 29
 Warning imports CustomImportOrder Extra separation in import group before 'org.apache.catalina.LifecycleException' 36
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsAuthProvider' 42

waffle/apache/WaffleAuthenticatorBaseTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'java.io.IOException' 28
 Warning imports CustomImportOrder Extra separation in import group before 'org.apache.catalina.connector.Request' 30
 Warning naming AbbreviationAsWordInName Abbreviation in name 'should_accept_NTLM_protocol' must contain no more than '1' consecutive capital letters. 94

waffle/apache/WindowsAccountTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'org.junit.jupiter.api.Assertions' 35
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.mock.MockWindowsAccount' 39

waffle/apache/WindowsRealm.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'java.security.Principal' 28
 Warning imports CustomImportOrder Extra separation in import group before 'org.apache.catalina.realm.RealmBase' 30
 Warning javadoc JavadocParagraph <p> tag should be placed immediately before the first word, with no space after. 42
 Warning javadoc JavadocParagraph <p> tag should be preceded with an empty line. 42

waffle/apache/catalina/SimpleHttpRequest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'java.security.Principal' 28
 Warning imports CustomImportOrder Extra separation in import group before 'mockit.Mocked' 32
 Warning imports CustomImportOrder Extra separation in import group before 'org.apache.catalina.connector.Request' 34
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 49
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 56
 Warning naming AbbreviationAsWordInName Abbreviation in name 'requestURI' must contain no more than '1' consecutive capital letters. 61
 Warning naming AbbreviationAsWordInName Abbreviation in name 'setRequestURI' must contain no more than '1' consecutive capital letters. 249

waffle/apache/catalina/SimpleHttpResponse.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'org.apache.catalina.connector.Response' 32