Checkstyle Results

The following document contains the results of Checkstyle 14.1.0 with checkstyle.xml ruleset.

Summary

Files  Info  Warnings  Errors
71 0 123 0

Files

File  I  W  E
waffle/jaas/RolePrincipalTest.java 0 1 0
waffle/jaas/UserPrincipalTest.java 0 1 0
waffle/jaas/UsernamePasswordCallbackHandler.java 0 1 0
waffle/jaas/WindowsLoginModule.java 0 3 0
waffle/jaas/WindowsLoginModuleTest.java 0 5 0
waffle/servlet/AutoDisposableWindowsPrincipal.java 0 1 0
waffle/servlet/AutoDisposableWindowsPrincipalTest.java 0 3 0
waffle/servlet/CorsAwareNegotiateSecurityFilter.java 0 4 0
waffle/servlet/CorsAwareNegotiateSecurityFilterTest.java 0 3 0
waffle/servlet/NegotiateRequestWrapper.java 0 1 0
waffle/servlet/NegotiateRequestWrapperTest.java 0 3 0
waffle/servlet/NegotiateSecurityFilter.java 0 5 0
waffle/servlet/NegotiateSecurityFilterTest.java 0 7 0
waffle/servlet/WaffleInfoServlet.java 0 4 0
waffle/servlet/WindowsPrincipal.java 0 2 0
waffle/servlet/WindowsPrincipalTest.java 0 2 0
waffle/servlet/spi/BasicSecurityFilterProvider.java 0 3 0
waffle/servlet/spi/BasicSecurityFilterProviderTest.java 0 4 0
waffle/servlet/spi/NegotiateSecurityFilterProvider.java 0 3 0
waffle/servlet/spi/NegotiateSecurityFilterProviderTest.java 0 4 0
waffle/servlet/spi/SecurityFilterProvider.java 0 2 0
waffle/servlet/spi/SecurityFilterProviderCollection.java 0 4 0
waffle/servlet/spi/SecurityFilterProviderCollectionTest.java 0 3 0
waffle/util/AuthorizationHeader.java 0 3 0
waffle/util/CorsPreFlightCheck.java 0 2 0
waffle/util/CorsPreFlightCheckTest.java 0 2 0
waffle/util/SPNegoMessage.java 0 1 0
waffle/util/SPNegoMessageTest.java 0 1 0
waffle/util/WaffleInfo.java 0 8 0
waffle/util/WaffleInfoTest.java 0 3 0
waffle/util/cache/Cache.java 0 6 0
waffle/util/cache/CacheSupplier.java 0 1 0
waffle/util/cache/CaffeineCache.java 0 2 0
waffle/windows/auth/IWindowsAccount.java 0 1 0
waffle/windows/auth/IWindowsAuthProvider.java 0 1 0
waffle/windows/auth/IWindowsComputer.java 0 1 0
waffle/windows/auth/IWindowsCredentialsHandle.java 0 1 0
waffle/windows/auth/IWindowsDomain.java 0 1 0
waffle/windows/auth/IWindowsIdentity.java 0 1 0
waffle/windows/auth/IWindowsImpersonationContext.java 0 1 0
waffle/windows/auth/IWindowsSecurityContext.java 0 1 0
waffle/windows/auth/WindowsAccountTest.java 0 2 0
waffle/windows/auth/WindowsAccountValueTest.java 0 1 0
waffle/windows/auth/WindowsCredentialsHandleTest.java 0 1 0
waffle/windows/auth/WindowsSecurityContextTest.java 0 1 0
waffle/windows/auth/impl/WindowsAccountImpl.java 0 1 0
waffle/windows/auth/impl/WindowsAuthProviderImpl.java 0 2 0
waffle/windows/auth/impl/WindowsComputerImpl.java 0 2 0
waffle/windows/auth/impl/WindowsCredentialsHandleImpl.java 0 1 0
waffle/windows/auth/impl/WindowsDomainImpl.java 0 1 0
waffle/windows/auth/impl/WindowsIdentityImpersonationContextImpl.java 0 1 0
waffle/windows/auth/impl/WindowsIdentityImpl.java 0 2 0
waffle/windows/auth/impl/WindowsSecurityContextImpersonationContextImpl.java 0 1 0
waffle/windows/auth/impl/WindowsSecurityContextImpl.java 0 1 0

Rules

Category Rule Violations Severity
coding OverloadMethodsDeclarationOrder 1  Warning
imports CustomImportOrder
  • separateLineBetweenGroups: "true"
  • sortImportsInGroupAlphabetically: "true"
  • customImportOrderRules: "STATIC###THIRD_PARTY_PACKAGE"
  • tokens: "IMPORT, STATIC_IMPORT, PACKAGE_DEF"
95  Warning
javadoc JavadocParagraph 5  Warning
SummaryJavadoc
  • forbiddenSummaryFragments: "^@return the *|^This method returns |^A [{]@code [a-zA-Z0-9]+[}]( is a )"
5  Warning
naming AbbreviationAsWordInName
  • tokens: "CLASS_DEF, INTERFACE_DEF, ENUM_DEF, ANNOTATION_DEF, ANNOTATION_FIELD_DEF, PARAMETER_DEF, VARIABLE_DEF, METHOD_DEF, PATTERN_VARIABLE_DEF, RECORD_DEF, RECORD_COMPONENT_DEF"
  • ignoreFinal: "false"
  • allowedAbbreviations: "XML,URL"
  • allowedAbbreviationLength: "0"
14  Warning
sizes LineLength
  • fileExtensions: "java"
  • max: "120"
  • ignorePattern: "^package.*|^import.*|a href|href|http://|https://|ftp://"
3  Error

Details

waffle/jaas/RolePrincipalTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'org.junit.jupiter.api.Assertions' 18

waffle/jaas/UserPrincipalTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'org.junit.jupiter.api.Assertions' 18

waffle/jaas/UsernamePasswordCallbackHandler.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'javax.security.auth.callback.Callback' 11

waffle/jaas/WindowsLoginModule.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'javax.security.auth.Subject' 18
 Warning imports CustomImportOrder Extra separation in import group before 'org.slf4j.Logger' 27
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsAccount' 30

waffle/jaas/WindowsLoginModuleTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'javax.security.auth.Subject' 16
 Warning imports CustomImportOrder Extra separation in import group before 'mockit.Expectations' 23
 Warning imports CustomImportOrder Extra separation in import group before 'org.junit.jupiter.api.Assertions' 26
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.PrincipalFormat' 31
 Warning naming AbbreviationAsWordInName Abbreviation in name 'login_throwIOException' must contain no more than '1' consecutive capital letters. 215

waffle/servlet/AutoDisposableWindowsPrincipal.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsIdentity' 12

waffle/servlet/AutoDisposableWindowsPrincipalTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'mockit.Expectations' 11
 Warning imports CustomImportOrder Extra separation in import group before 'org.junit.jupiter.api.Assertions' 14
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsAccount' 17

waffle/servlet/CorsAwareNegotiateSecurityFilter.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'java.io.IOException' 17
 Warning imports CustomImportOrder Extra separation in import group before 'org.slf4j.Logger' 19
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.util.AuthorizationHeader' 22
 Warning sizes LineLength Line is longer than 120 characters (found 122). 58

waffle/servlet/CorsAwareNegotiateSecurityFilterTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'mockit.Expectations' 14
 Warning imports CustomImportOrder Extra separation in import group before 'org.junit.jupiter.api.Test' 19
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.util.CorsPreFlightCheck' 21

waffle/servlet/NegotiateRequestWrapper.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'java.security.Principal' 12

waffle/servlet/NegotiateRequestWrapperTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'mockit.Expectations' 11
 Warning imports CustomImportOrder Extra separation in import group before 'org.junit.jupiter.api.Assertions' 14
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsAccount' 18

waffle/servlet/NegotiateSecurityFilter.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'java.io.IOException' 19
 Warning imports CustomImportOrder Extra separation in import group before 'javax.security.auth.Subject' 28
 Warning imports CustomImportOrder Extra separation in import group before 'org.slf4j.Logger' 30
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.servlet.spi.SecurityFilterProvider' 33
 Warning naming AbbreviationAsWordInName Abbreviation in name 'disableSSO' must contain no more than '1' consecutive capital letters. 85

waffle/servlet/NegotiateSecurityFilterTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'java.lang.reflect.Field' 14
 Warning imports CustomImportOrder Extra separation in import group before 'mockit.Expectations' 18
 Warning imports CustomImportOrder Extra separation in import group before 'org.junit.jupiter.api.Assertions' 23
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.util.CorsPreFlightCheck' 26
 Warning sizes LineLength Line is longer than 120 characters (found 131). 82
 Warning naming AbbreviationAsWordInName Abbreviation in name 'testExcludeCorsAndOAUTHBearerAuthorization_doFilter' must contain no more than '1' consecutive capital letters. 130
 Warning sizes LineLength Line is longer than 120 characters (found 131). 148

waffle/servlet/WaffleInfoServlet.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'java.io.IOException' 13
 Warning imports CustomImportOrder Extra separation in import group before 'javax.xml.XMLConstants' 18
 Warning imports CustomImportOrder Extra separation in import group before 'org.slf4j.Logger' 27
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.util.WaffleInfo' 32

waffle/servlet/WindowsPrincipal.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsAccount' 16
 Warning coding OverloadMethodsDeclarationOrder All overloaded methods should be placed next to each other. Previous overloaded method located at line '107'. 138

waffle/servlet/WindowsPrincipalTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'org.junit.jupiter.api.Assertions' 12
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsAccount' 15

waffle/servlet/spi/BasicSecurityFilterProvider.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'java.io.IOException' 12
 Warning imports CustomImportOrder Extra separation in import group before 'org.slf4j.Logger' 16
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.util.AuthorizationHeader' 19

waffle/servlet/spi/BasicSecurityFilterProviderTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'java.security.InvalidParameterException' 12
 Warning imports CustomImportOrder Extra separation in import group before 'mockit.Expectations' 14
 Warning imports CustomImportOrder Extra separation in import group before 'org.junit.jupiter.api.Assertions' 18
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsAuthProvider' 22

waffle/servlet/spi/NegotiateSecurityFilterProvider.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'java.io.IOException' 12
 Warning imports CustomImportOrder Extra separation in import group before 'org.slf4j.Logger' 18
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.util.AuthorizationHeader' 21

waffle/servlet/spi/NegotiateSecurityFilterProviderTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'java.util.Arrays' 11
 Warning imports CustomImportOrder Extra separation in import group before 'mockit.Mocked' 14
 Warning imports CustomImportOrder Extra separation in import group before 'org.junit.jupiter.api.Assertions' 17
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsAuthProvider' 21

waffle/servlet/spi/SecurityFilterProvider.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'java.io.IOException' 12
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsIdentity' 14

waffle/servlet/spi/SecurityFilterProviderCollection.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'jakarta.servlet.http.HttpServletRequest' 11
 Warning imports CustomImportOrder Extra separation in import group before 'java.io.IOException' 14
 Warning imports CustomImportOrder Extra separation in import group before 'org.slf4j.Logger' 20
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.util.AuthorizationHeader' 23

waffle/servlet/spi/SecurityFilterProviderCollectionTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'mockit.Mocked' 12
 Warning imports CustomImportOrder Extra separation in import group before 'org.junit.jupiter.api.Assertions' 15
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsAuthProvider' 18

waffle/util/AuthorizationHeader.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'java.util.Base64' 11
 Warning imports CustomImportOrder Extra separation in import group before 'org.slf4j.Logger' 14
 Warning naming AbbreviationAsWordInName Abbreviation in name 'isSPNegTokenInitMessage' must contain no more than '1' consecutive capital letters. 133

waffle/util/CorsPreFlightCheck.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'java.util.ArrayList' 11
 Warning imports CustomImportOrder Extra separation in import group before 'org.slf4j.Logger' 15

waffle/util/CorsPreFlightCheckTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'mockit.Expectations' 11
 Warning imports CustomImportOrder Extra separation in import group before 'org.junit.jupiter.api.Assertions' 15

waffle/util/SPNegoMessage.java

Severity Category Rule Message Line
 Warning naming AbbreviationAsWordInName Abbreviation in name 'SPNegoMessage' must contain no more than '1' consecutive capital letters. 12

waffle/util/SPNegoMessageTest.java

Severity Category Rule Message Line
 Warning naming AbbreviationAsWordInName Abbreviation in name 'SPNegoMessageTest' must contain no more than '1' consecutive capital letters. 15

waffle/util/WaffleInfo.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'java.awt.Desktop' 15
 Warning imports CustomImportOrder Extra separation in import group before 'javax.xml.XMLConstants' 26
 Warning imports CustomImportOrder Extra separation in import group before 'org.slf4j.Logger' 36
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsAccount' 41
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 54
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 62
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 70
 Warning javadoc JavadocParagraph <p> tag should be preceded with an empty line. 86

waffle/util/WaffleInfoTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'javax.xml.parsers.DocumentBuilderFactory' 11
 Warning imports CustomImportOrder Extra separation in import group before 'org.junit.jupiter.api.Assertions' 15
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsAccount' 22

waffle/util/cache/Cache.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'org.slf4j.Logger' 12
 Warning javadoc JavadocParagraph <p> tag should be preceded with an empty line. 30
 Warning javadoc SummaryJavadoc First sentence of Javadoc is missing an ending period. 70
 Warning javadoc SummaryJavadoc First sentence of Javadoc is missing an ending period. 82
 Warning javadoc SummaryJavadoc First sentence of Javadoc is missing an ending period. 94
 Warning javadoc SummaryJavadoc First sentence of Javadoc is missing an ending period. 104

waffle/util/cache/CacheSupplier.java

Severity Category Rule Message Line
 Warning javadoc SummaryJavadoc First sentence of Javadoc is missing an ending period. 14

waffle/util/cache/CaffeineCache.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'java.time.Duration' 11
 Warning imports CustomImportOrder Extra separation in import group before 'org.checkerframework.checker.index.qual.NonNegative' 13

waffle/windows/auth/IWindowsAccount.java

Severity Category Rule Message Line
 Warning naming AbbreviationAsWordInName Abbreviation in name 'IWindowsAccount' must contain no more than '1' consecutive capital letters. 12

waffle/windows/auth/IWindowsAuthProvider.java

Severity Category Rule Message Line
 Warning naming AbbreviationAsWordInName Abbreviation in name 'IWindowsAuthProvider' must contain no more than '1' consecutive capital letters. 12

waffle/windows/auth/IWindowsComputer.java

Severity Category Rule Message Line
 Warning naming AbbreviationAsWordInName Abbreviation in name 'IWindowsComputer' must contain no more than '1' consecutive capital letters. 12

waffle/windows/auth/IWindowsCredentialsHandle.java

Severity Category Rule Message Line
 Warning naming AbbreviationAsWordInName Abbreviation in name 'IWindowsCredentialsHandle' must contain no more than '1' consecutive capital letters. 14

waffle/windows/auth/IWindowsDomain.java

Severity Category Rule Message Line
 Warning naming AbbreviationAsWordInName Abbreviation in name 'IWindowsDomain' must contain no more than '1' consecutive capital letters. 12

waffle/windows/auth/IWindowsIdentity.java

Severity Category Rule Message Line
 Warning naming AbbreviationAsWordInName Abbreviation in name 'IWindowsIdentity' must contain no more than '1' consecutive capital letters. 12

waffle/windows/auth/IWindowsImpersonationContext.java

Severity Category Rule Message Line
 Warning naming AbbreviationAsWordInName Abbreviation in name 'IWindowsImpersonationContext' must contain no more than '1' consecutive capital letters. 12

waffle/windows/auth/IWindowsSecurityContext.java

Severity Category Rule Message Line
 Warning naming AbbreviationAsWordInName Abbreviation in name 'IWindowsSecurityContext' must contain no more than '1' consecutive capital letters. 16

waffle/windows/auth/WindowsAccountTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'org.junit.jupiter.api.Assertions' 13
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.impl.WindowsAccountImpl' 18

waffle/windows/auth/WindowsAccountValueTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'org.junit.jupiter.api.Assertions' 12

waffle/windows/auth/WindowsCredentialsHandleTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.impl.WindowsCredentialsHandleImpl' 12

waffle/windows/auth/WindowsSecurityContextTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.impl.WindowsAccountImpl' 14

waffle/windows/auth/impl/WindowsAccountImpl.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsAccount' 14

waffle/windows/auth/impl/WindowsAuthProviderImpl.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'java.net.InetAddress' 23
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.util.cache.Cache' 28

waffle/windows/auth/impl/WindowsComputerImpl.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'java.util.ArrayList' 13
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsComputer' 16

waffle/windows/auth/impl/WindowsCredentialsHandleImpl.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsCredentialsHandle' 16

waffle/windows/auth/impl/WindowsDomainImpl.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsDomain' 11

waffle/windows/auth/impl/WindowsIdentityImpersonationContextImpl.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsImpersonationContext' 14

waffle/windows/auth/impl/WindowsIdentityImpl.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'java.util.ArrayList' 15
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsAccount' 18

waffle/windows/auth/impl/WindowsSecurityContextImpersonationContextImpl.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsImpersonationContext' 14

waffle/windows/auth/impl/WindowsSecurityContextImpl.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.IWindowsCredentialsHandle' 19