Checkstyle Results

The following document contains the results of Checkstyle 10.12.7 with checkstyle.xml ruleset.

Summary

Files  Info  Warnings  Errors
17 0 44 0

Files

File  I  W  E
waffle/spring/DelegatingNegotiateSecurityFilter.java 0 4 0
waffle/spring/DelegatingNegotiateSecurityFilterTest.java 0 6 0
waffle/spring/FqnGrantedAuthorityFactory.java 0 1 0
waffle/spring/FqnGrantedAuthorityFactoryTest.java 0 1 0
waffle/spring/GrantedAuthorityFactory.java 0 1 0
waffle/spring/ImpersonateTest.java 0 4 0
waffle/spring/NegotiateSecurityFilter.java 0 4 0
waffle/spring/NegotiateSecurityFilterEntryPoint.java 0 3 0
waffle/spring/NegotiateSecurityFilterEntryPointTest.java 0 4 0
waffle/spring/NegotiateSecurityFilterTest.java 0 4 0
waffle/spring/WindowsAuthenticationProvider.java 0 4 0
waffle/spring/WindowsAuthenticationProviderTest.java 0 2 0
waffle/spring/WindowsAuthenticationToken.java 0 2 0
waffle/spring/WindowsAuthenticationTokenTest.java 0 2 0
waffle/spring/handlers/CustomAccessDeniedHandler.java 0 2 0

Rules

Category Rule Violations Severity
design OneTopLevelClass 1  Warning
imports CustomImportOrder
  • separateLineBetweenGroups: "true"
  • sortImportsInGroupAlphabetically: "true"
  • customImportOrderRules: "STATIC###THIRD_PARTY_PACKAGE"
  • tokens: "IMPORT, STATIC_IMPORT, PACKAGE_DEF"
35  Warning
javadoc JavadocParagraph 4  Warning
naming AbbreviationAsWordInName
  • tokens: "CLASS_DEF, INTERFACE_DEF, ENUM_DEF, ANNOTATION_DEF, ANNOTATION_FIELD_DEF, PARAMETER_DEF, VARIABLE_DEF, METHOD_DEF, PATTERN_VARIABLE_DEF, RECORD_DEF, RECORD_COMPONENT_DEF"
  • ignoreFinal: "false"
  • allowedAbbreviations: "XML,URL"
  • allowedAbbreviationLength: "0"
2  Warning
sizes LineLength
  • fileExtensions: "java"
  • max: "120"
  • ignorePattern: "^package.*|^import.*|a href|href|http://|https://|ftp://"
2  Error

Details

waffle/spring/DelegatingNegotiateSecurityFilter.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'javax.servlet.ServletException' 28
 Warning imports CustomImportOrder Extra separation in import group before 'org.slf4j.Logger' 32
 Warning javadoc JavadocParagraph <p> tag should be placed immediately before the first word, with no space after. 46
 Warning javadoc JavadocParagraph <p> tag should be preceded with an empty line. 46

waffle/spring/DelegatingNegotiateSecurityFilterTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'javax.servlet.ServletException' 34
 Warning imports CustomImportOrder Extra separation in import group before 'org.junit.jupiter.api.AfterEach' 38
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.mock.http.SimpleFilterChain' 53
 Warning javadoc JavadocParagraph <p> tag should be placed immediately before the first word, with no space after. 187
 Warning javadoc JavadocParagraph <p> tag should be preceded with an empty line. 187
 Warning design OneTopLevelClass Top-level class CustomAuthenticationSuccessHandler has to reside in its own source file. 191

waffle/spring/FqnGrantedAuthorityFactory.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.WindowsAccount' 29

waffle/spring/FqnGrantedAuthorityFactoryTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.mock.MockWindowsAccount' 31

waffle/spring/GrantedAuthorityFactory.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.WindowsAccount' 28

waffle/spring/ImpersonateTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'java.io.IOException' 34
 Warning imports CustomImportOrder Extra separation in import group before 'javax.servlet.ServletException' 39
 Warning imports CustomImportOrder Extra separation in import group before 'org.junit.jupiter.api.AfterEach' 41
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.mock.MockWindowsAccount' 49

waffle/spring/NegotiateSecurityFilter.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'javax.servlet.FilterChain' 29
 Warning imports CustomImportOrder Extra separation in import group before 'org.slf4j.Logger' 36
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.servlet.AutoDisposableWindowsPrincipal' 43
 Warning sizes LineLength Line is longer than 120 characters (found 123). 75

waffle/spring/NegotiateSecurityFilterEntryPoint.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'javax.servlet.ServletException' 28
 Warning imports CustomImportOrder Extra separation in import group before 'org.slf4j.Logger' 32
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.servlet.spi.SecurityFilterProviderCollection' 37

waffle/spring/NegotiateSecurityFilterEntryPointTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'javax.servlet.ServletException' 28
 Warning imports CustomImportOrder Extra separation in import group before 'org.junit.jupiter.api.AfterEach' 30
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.mock.http.SimpleHttpRequest' 38
 Warning naming AbbreviationAsWordInName Abbreviation in name 'testChallengeGET' must contain no more than '1' consecutive capital letters. 79

waffle/spring/NegotiateSecurityFilterTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'javax.servlet.ServletException' 34
 Warning imports CustomImportOrder Extra separation in import group before 'org.junit.jupiter.api.AfterEach' 36
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.mock.http.SimpleFilterChain' 47
 Warning naming AbbreviationAsWordInName Abbreviation in name 'testNoChallengeGET' must contain no more than '1' consecutive capital letters. 123

waffle/spring/WindowsAuthenticationProvider.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'java.util.Locale' 28
 Warning imports CustomImportOrder Extra separation in import group before 'org.slf4j.Logger' 30
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.servlet.WindowsPrincipal' 38
 Warning sizes LineLength Line is longer than 120 characters (found 123). 64

waffle/spring/WindowsAuthenticationProviderTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'org.junit.jupiter.api.AfterEach' 31
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.mock.MockWindowsAuthProvider' 42

waffle/spring/WindowsAuthenticationToken.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'org.springframework.security.core.Authentication' 29
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.servlet.WindowsPrincipal' 33

waffle/spring/WindowsAuthenticationTokenTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'org.junit.jupiter.api.Assertions' 31
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.mock.MockWindowsIdentity' 36

waffle/spring/handlers/CustomAccessDeniedHandler.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'javax.servlet.ServletException' 28
 Warning imports CustomImportOrder Extra separation in import group before 'org.springframework.security.access.AccessDeniedException' 32