Built by Maven

Checkstyle Results

The following document contains the results of Checkstyle 14.1.0 with checkstyle.xml ruleset.

Summary

Files  Info  Warnings  Errors
18 0 45 0

Files

File  I  W  E
waffle/spring/DelegatingNegotiateSecurityFilter.java 0 3 0
waffle/spring/DelegatingNegotiateSecurityFilterTest.java 0 5 0
waffle/spring/FqnGrantedAuthorityFactory.java 0 2 0
waffle/spring/FqnGrantedAuthorityFactoryTest.java 0 1 0
waffle/spring/GrantedAuthorityFactory.java 0 1 0
waffle/spring/ImpersonateTest.java 0 4 0
waffle/spring/NegotiateSecurityFilter.java 0 4 0
waffle/spring/NegotiateSecurityFilterEntryPoint.java 0 3 0
waffle/spring/NegotiateSecurityFilterEntryPointTest.java 0 4 0
waffle/spring/NegotiateSecurityFilterTest.java 0 5 0
waffle/spring/WindowsAuthenticationProvider.java 0 4 0
waffle/spring/WindowsAuthenticationProviderTest.java 0 3 0
waffle/spring/WindowsAuthenticationToken.java 0 2 0
waffle/spring/WindowsAuthenticationTokenTest.java 0 2 0
waffle/spring/handlers/CustomAccessDeniedHandler.java 0 2 0

Rules

Category Rule Violations Severity
design OneTopLevelClass 1  Warning
imports CustomImportOrder
  • separateLineBetweenGroups: "true"
  • sortImportsInGroupAlphabetically: "true"
  • customImportOrderRules: "STATIC###THIRD_PARTY_PACKAGE"
  • tokens: "IMPORT, STATIC_IMPORT, PACKAGE_DEF"
 36  Warning
javadoc JavadocParagraph 2  Warning
naming AbbreviationAsWordInName
  • tokens: "CLASS_DEF, INTERFACE_DEF, ENUM_DEF, ANNOTATION_DEF, ANNOTATION_FIELD_DEF, PARAMETER_DEF, VARIABLE_DEF, METHOD_DEF, PATTERN_VARIABLE_DEF, RECORD_DEF, RECORD_COMPONENT_DEF"
  • ignoreFinal: "false"
  • allowedAbbreviations: "XML,URL"
  • allowedAbbreviationLength: "0"
 2  Warning
sizes LineLength
  • fileExtensions: "java"
  • max: "120"
  • ignorePattern: "^package.*|^import.*|a href|href|http://|https://|ftp://"
 4  Error

Details

waffle/spring/DelegatingNegotiateSecurityFilter.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'javax.servlet.ServletException' 11
 Warning imports CustomImportOrder Extra separation in import group before 'org.slf4j.Logger' 15
 Warning javadoc JavadocParagraph <p> tag should be preceded with an empty line. 29

waffle/spring/DelegatingNegotiateSecurityFilterTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'javax.servlet.ServletException' 17
 Warning imports CustomImportOrder Extra separation in import group before 'org.junit.jupiter.api.AfterEach' 21
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.mock.http.SimpleFilterChain' 36
 Warning javadoc JavadocParagraph <p> tag should be preceded with an empty line. 168
 Warning design OneTopLevelClass Top-level class CustomAuthenticationSuccessHandler has to reside in its own source file. 172

waffle/spring/FqnGrantedAuthorityFactory.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'org.springframework.security.core.GrantedAuthority' 11
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.WindowsAccount' 14

waffle/spring/FqnGrantedAuthorityFactoryTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.mock.MockWindowsAccount' 14

waffle/spring/GrantedAuthorityFactory.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.windows.auth.WindowsAccount' 11

waffle/spring/ImpersonateTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'java.io.IOException' 16
 Warning imports CustomImportOrder Extra separation in import group before 'javax.servlet.ServletException' 21
 Warning imports CustomImportOrder Extra separation in import group before 'org.junit.jupiter.api.AfterEach' 23
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.mock.MockWindowsAccount' 31

waffle/spring/NegotiateSecurityFilter.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'javax.servlet.FilterChain' 12
 Warning imports CustomImportOrder Extra separation in import group before 'org.slf4j.Logger' 19
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.servlet.AutoDisposableWindowsPrincipal' 26
 Warning sizes LineLength Line is longer than 120 characters (found 123). 58

waffle/spring/NegotiateSecurityFilterEntryPoint.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'javax.servlet.ServletException' 11
 Warning imports CustomImportOrder Extra separation in import group before 'org.slf4j.Logger' 15
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.servlet.spi.SecurityFilterProviderCollection' 20

waffle/spring/NegotiateSecurityFilterEntryPointTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'javax.servlet.ServletException' 11
 Warning imports CustomImportOrder Extra separation in import group before 'org.junit.jupiter.api.AfterEach' 13
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.mock.http.SimpleHttpRequest' 21
 Warning naming AbbreviationAsWordInName Abbreviation in name 'testChallengeGET' must contain no more than '1' consecutive capital letters. 62

waffle/spring/NegotiateSecurityFilterTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'javax.servlet.ServletException' 17
 Warning imports CustomImportOrder Extra separation in import group before 'org.junit.jupiter.api.AfterEach' 19
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.mock.http.SimpleFilterChain' 30
 Warning naming AbbreviationAsWordInName Abbreviation in name 'testNoChallengeGET' must contain no more than '1' consecutive capital letters. 106
 Warning sizes LineLength Line is longer than 120 characters (found 164). 245

waffle/spring/WindowsAuthenticationProvider.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'java.util.Locale' 11
 Warning imports CustomImportOrder Extra separation in import group before 'org.slf4j.Logger' 13
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.servlet.WindowsPrincipal' 21
 Warning sizes LineLength Line is longer than 120 characters (found 123). 47

waffle/spring/WindowsAuthenticationProviderTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'org.junit.jupiter.api.AfterEach' 14
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.mock.MockWindowsAuthProvider' 25
 Warning sizes LineLength Line is longer than 120 characters (found 159). 178

waffle/spring/WindowsAuthenticationToken.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'org.springframework.security.core.Authentication' 12
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.servlet.WindowsPrincipal' 16

waffle/spring/WindowsAuthenticationTokenTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'org.junit.jupiter.api.Assertions' 14
 Warning imports CustomImportOrder Extra separation in import group before 'waffle.mock.MockWindowsIdentity' 19

waffle/spring/handlers/CustomAccessDeniedHandler.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Extra separation in import group before 'javax.servlet.ServletException' 11
 Warning imports CustomImportOrder Extra separation in import group before 'org.springframework.security.access.AccessDeniedException' 15