SpotBugs Bug Detector Report

The following document contains the results of SpotBugs

SpotBugs Version is 4.10.4

Threshold is medium

Effort is

Summary

Classes	Bugs	Errors	Missing Classes
19	21	0	0

Files

Class	Bugs
waffle.spring.CustomAuthenticationSuccessHandler	1
waffle.spring.DelegatingNegotiateSecurityFilter	5
waffle.spring.DelegatingNegotiateSecurityFilterTest	1
waffle.spring.ImpersonateTest	2
waffle.spring.NegotiateSecurityFilter	3
waffle.spring.NegotiateSecurityFilterEntryPointTest	2
waffle.spring.NegotiateSecurityFilterTest	1
waffle.spring.WindowsAuthenticationProviderTest	2
waffle.spring.WindowsAuthenticationToken	2
waffle.spring.WindowsAuthenticationTokenTest	2

waffle.spring.CustomAuthenticationSuccessHandler

Bug	Category	Details	Line	Priority
waffle.spring.CustomAuthenticationSuccessHandler.onAuthenticationSuccess(HttpServletRequest, HttpServletResponse, Authentication) may expose internal representation by storing an externally mutable object into CustomAuthenticationSuccessHandler.authentication	MALICIOUS_CODE	EI_EXPOSE_REP2	180	Medium

waffle.spring.DelegatingNegotiateSecurityFilter

Bug	Category	Details	Line	Priority
To make log readable, log format () should contain non-sign character.	BAD_PRACTICE	SLF4J_SIGN_ONLY_FORMAT	140	Medium
To make log readable, log format () should contain non-sign character.	BAD_PRACTICE	SLF4J_SIGN_ONLY_FORMAT	186	Medium
To make log readable, log format () should contain non-sign character.	BAD_PRACTICE	SLF4J_SIGN_ONLY_FORMAT	190	Medium
To make log readable, log format () should contain non-sign character.	BAD_PRACTICE	SLF4J_SIGN_ONLY_FORMAT	215	Medium
To make log readable, log format () should contain non-sign character.	BAD_PRACTICE	SLF4J_SIGN_ONLY_FORMAT	219	Medium

waffle.spring.DelegatingNegotiateSecurityFilterTest

Bug	Category	Details	Line	Priority
Method waffle.spring.DelegatingNegotiateSecurityFilterTest.testNegotiate() does not presize the allocation of a collection	PERFORMANCE	PSC_PRESIZE_COLLECTIONS	116	Medium

waffle.spring.ImpersonateTest

Bug	Category	Details	Line	Priority
Method waffle.spring.ImpersonateTest.testImpersonateDisabled() appears to call the same method on the same object redundantly	PERFORMANCE	PRMC_POSSIBLY_REDUNDANT_METHOD_CALLS	161	High
Method waffle.spring.ImpersonateTest.testImpersonateEnabled() appears to call the same method on the same object redundantly	PERFORMANCE	PRMC_POSSIBLY_REDUNDANT_METHOD_CALLS	120	High

waffle.spring.NegotiateSecurityFilter

Bug	Category	Details	Line	Priority
This use of org/slf4j/Logger.debug(Ljava/lang/String;[Ljava/lang/Object;)V might be used to include CRLF characters into log messages	SECURITY	CRLF_INJECTION_LOGS	78	Medium
Unconstrained method waffle.spring.NegotiateSecurityFilter.sendUnauthorized(HttpServletResponse, boolean) converts checked exception to unchecked	STYLE	EXS_EXCEPTION_SOFTENING_NO_CONSTRAINTS	194	High
To make log readable, log format () should contain non-sign character.	BAD_PRACTICE	SLF4J_SIGN_ONLY_FORMAT	97	Medium

waffle.spring.NegotiateSecurityFilterEntryPointTest

Bug	Category	Details	Line	Priority
Method waffle.spring.NegotiateSecurityFilterEntryPointTest.testChallengeGET() accesses list or array with constant index	CORRECTNESS	CLI_CONSTANT_LIST_INDEX	70	Medium
Method waffle.spring.NegotiateSecurityFilterEntryPointTest.testChallengeGET() accesses list or array with constant index	CORRECTNESS	CLI_CONSTANT_LIST_INDEX	71	Medium

waffle.spring.NegotiateSecurityFilterTest

Bug	Category	Details	Line	Priority
Method waffle.spring.NegotiateSecurityFilterTest.testNegotiate() does not presize the allocation of a collection	PERFORMANCE	PSC_PRESIZE_COLLECTIONS	145	Medium

waffle.spring.WindowsAuthenticationProviderTest

Bug	Category	Details	Line	Priority
Method waffle.spring.WindowsAuthenticationProviderTest.testAuthenticate() does not presize the allocation of a collection	PERFORMANCE	PSC_PRESIZE_COLLECTIONS	98	Medium
Method waffle.spring.WindowsAuthenticationProviderTest.testAuthenticateWithCustomGrantedAuthorityFactory() does not presize the allocation of a collection	PERFORMANCE	PSC_PRESIZE_COLLECTIONS	129	Medium

waffle.spring.WindowsAuthenticationToken

Bug	Category	Details	Line	Priority
waffle.spring.WindowsAuthenticationToken.getAuthorities() may expose internal representation by returning WindowsAuthenticationToken.authorities	MALICIOUS_CODE	EI_EXPOSE_REP	91	Medium
Method new waffle.spring.WindowsAuthenticationToken(WindowsPrincipal, GrantedAuthorityFactory, GrantedAuthority) does not presize the allocation of a collection	PERFORMANCE	PSC_PRESIZE_COLLECTIONS	85	Medium

waffle.spring.WindowsAuthenticationTokenTest

Bug	Category	Details	Line	Priority
Method waffle.spring.WindowsAuthenticationTokenTest.testCustomGrantedAuthorityFactory() does not presize the allocation of a collection	PERFORMANCE	PSC_PRESIZE_COLLECTIONS	87	Medium
Method waffle.spring.WindowsAuthenticationTokenTest.testWindowsAuthenticationToken() does not presize the allocation of a collection	PERFORMANCE	PSC_PRESIZE_COLLECTIONS	60	Medium